Feat/use dark mode preference to set initial theme.light #861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FaberVitale
force-pushed
the
feat/use-user-dark-mode-preference
branch
from
ad0d2eb
to
c3ec188
Compare
FaberVitale
changed the title
FaberVitale
force-pushed
the
feat/use-user-dark-mode-preference
branch
from
c3ec188
to
9f6ba05
Compare
|
rebased |
Methuselah96
requested changes
Oct 30, 2021
FaberVitale
force-pushed
the
feat/use-user-dark-mode-preference
branch
from
9f6ba05
to
5a4b3e5
Compare
|
I've implemented the changes requested in #861 (comment) |
…ght` if user has not set a preferred theme
Error message: 0:0 error Parsing error: "parserOptions.project" has been set for @typescript-eslint/parser. The file does not match your project config: test/__mocks__/styleMock.ts. The file must be included in at least one of the projects provided
FaberVitale
force-pushed
the
feat/use-user-dark-mode-preference
branch
from
5a4b3e5
to
09f7a0c
Compare
Methuselah96
approved these changes
Nov 6, 2021
Methuselah96
reviewed
Nov 6, 2021
| @@ -3,6 +3,6 @@ module.exports = { | |||
| setupFilesAfterEnv: ['<rootDir>/test/setup.ts'], | |||
| testEnvironment: 'jsdom', | |||
| moduleNameMapper: { | |||
| '\\.css$': '<rootDir>/test/__mocks__/styleMock.ts', | |||
| '\\.css$': '<rootDir>/test/__mocks__/styleMock.js', | |||
There was a problem hiding this comment.
Was it causing problems for this to be ts?
There was a problem hiding this comment.
I do not recall exactly, luckily I wrote a detailed commit message.
chore(@redux-devtools/app): fix lint error
Error message:
0:0 error Parsing error: "parserOptions.project" has been set for @typescript-eslint/parser.
The file does not match your project config: test/__mocks__/styleMock.ts.
The file must be included in at least one of the projects providedThere was a problem hiding this comment.
Nice commit message! I wonder if this was fixed by #867.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Displays
@redux-devtools/appandredux-devtools-extensionin dark mode if the following conditions are all true:settings > themeform.